photom v2 roi selection for ablation demo #185
Conversation
There was a problem hiding this comment.
This is a great demo of how we can draw and ablate some points. I wasn't able to check what the ablate method does. My suggestion is to get the copylot logger and use the logging.logger.debug or logging.logger.info to have this spit out information. For example, I would at least logger.info('Ablation Button Pressed') and as logger.debug(f'Ablation coordinates {coordinates of the shape to ablate}))
I think this will be clear when you add the docstring, but it's not clear what does bidirectional means.
Some things that would be nice to have is the logic to delete the specific shapes. So for example, have a method/wrapper that pops() or removes() specific shapes. You can add a button called Delete in the GUI that if the shape is selected from the dropdown and you click delete that it gets removed.
|
This one is minor but if the spacing is too big the behaviour should be that it at least has 1 point in the ROI and also throw some |
Added: - drawing mode group in control window, includes roi selection and pattern dropdown, pattern spacing boxes, and deletion of shapes - scrollable widget behavior for laser control window - attributes to LaserMarkerWindow class to contain shapes Changed: - how displaying shapes are handled. shape/drawings are displayed by calling self.update() now - shapesUpdate signal to notify of new shapes added - updated mouse event handling to track and store Shape objects
-relative import for the crosshair
|
When I draw the different ROIs, and click apply. It only moves to position [0] and it freezes. It doesn't print the next positions. Do you have an idea on why that happens? |
There was a problem hiding this comment.
LGTM! Thanks for these new features @aaronalvarezcz. This looks great, so I am merging it.
This PR adds the feature that compromised the bulk of my work as an intern. It improves the PhotoM drawing mode capabilities, allowing the user to draw shapes/ROIs, fill them with patterns, and ablate over those patterns by interfacing with the hardware.
Future Enhancement
A good extension of this project is integrating it with on-the-fly segmentations and turning the segmentations into ROIs so they can be ablated. This will further automate and streamline the workflow for ablating with PhotoM.